use layoutmsg dispatcher

[ejiek]

With Hyperland v0.30.0 and this lib at v0.3.12 orientation dispatchers for master layout are failing with the following error:

A dispatcher retrurned a non `ok`, value which is probably a error: Invalid dispatcher was returned by it

While other dispatchers work just fine. I've tested with Exec.
The issue seems to be that layout specific discpathers have layoutmsg part. Dwindle | Master.

Futhermore, some general dispatcher are dublicated in layout specific ones. cyclenext is awaylable with layoutmsg and without.

ps. there are some layout specific dispatchers that are currently missing and they are not part of this PR as of now. I want to figure out if I'm on a right track to fix existing ones.

[yavko]

Looks good, and sorry for the late response. I will approve as soon as I get confirmation everything works 😛.

[yavko]

I just want to ask if you could make sure this works with the binding code found in config.rs:

hyprland-rs/src/config.rs

Line 133 in a8ca325

dispatcher = gen_dispatch_str(binding.dispatcher, false)?

Since it adds a sep (,). Which when using regular IPC isn't added. This is weird, but it saves a lot of boilerplate.

hyprland-rs/src/dispatch.rs

Lines 468 to 470 in a8ca325

	pub(crate) fn gen_dispatch_str(cmd: DispatchType, dispatch: bool) -> crate::Result<CommandContent> {
	use DispatchType::*;
	let sep = if dispatch { " " } else { "," };

[ejiek]

I've tried the following with different all the available params:

Dispatch::call(DispatchType::SwapWithMaster(
           hyprland::dispatch::SwapWithMasterParam::Child
         )).unwrap();

and

Dispatch::call(DispatchType::FocusMaster(
          hyprland::dispatch::FocusMasterParam::Master
        )).unwrap();

Both seem to work fine, though I haven't figured difference between child, master and auto while running my tests from a terminal.

[yavko]

Yeah, but I mean creating a keybind with hyprland-rs, as it uses the same dispatcher code, just replaces the formatting because IPC and binds have a different format.

[ejiek]

I'm sorry, I've tried to test it with bindings but was not able to get even the binding from the example working:

hyprland::bind!(SUPER, Key, "t" => ToggleFloating, None).unwrap();

It returns Ok(()) but there is nothing new in hyprctl binds or an actual behavior.

[yavko]

I'm sorry, I've tried to test it with bindings but was not able to get even the binding from the example working:

hyprland::bind!(SUPER, Key, "t" => ToggleFloating, None).unwrap();

It returns Ok(()) but there is nothing new in hyprctl binds or an actual behavior.

I'm sorry if this is too much to ask, but could you maybe add a println to check the command it's generating, and trying it with hyprctl since I'm not on hyprland at the moment. I really only want to merge this, if the binding works, as binding layout commands is pretty essential imo.