core: avoid out-of-bound reads in getColorFromPixel

fixes #92
hyprwm · Oct 24, 2024 · 17e1ebe · 17e1ebe
1 parent 185be7c
commit 17e1ebe
Showing 1 changed file with 5 additions and 0 deletions.
diff --git a/src/hyprpicker.cpp b/src/hyprpicker.cpp
@@ -457,6 +457,11 @@ void CHyprpicker::renderSurface(CLayerSurface* pSurface, bool forceInactive) {
 }
 
 CColor CHyprpicker::getColorFromPixel(CLayerSurface* pLS, Vector2D pix) {
+    pix = pix.floor();
+
+    if (pix.x >= pLS->screenBuffer->pixelSize.x || pix.y >= pLS->screenBuffer->pixelSize.y)
+        return CColor{0, 0, 0, 0};
+
     void* dataSrc = pLS->screenBuffer->paddedData ? pLS->screenBuffer->paddedData : pLS->screenBuffer->data;
     struct pixel {
         unsigned char blue;