Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use xkbcommon for keyboard event handling #43

Merged
merged 1 commit into from
Oct 11, 2023

Conversation

TheOnlyMrCat
Copy link
Contributor

Fixes #41.

This is my first time writing C++ in a long time, so I might have put some things in the wrong place.

Errors in initialising xkb are logged, but not treated as fatal. If we can't initialise xkb, we just don't handle keypresses at all.

src/hyprpicker.cpp Outdated Show resolved Hide resolved
src/events/Events.cpp Outdated Show resolved Hide resolved
src/hyprpicker.cpp Outdated Show resolved Hide resolved
Copy link
Member

@vaxerski vaxerski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, I am a coconut

@vaxerski
Copy link
Member

thanks!

@vaxerski vaxerski merged commit 94010d6 into hyprwm:main Oct 11, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cancel with actual Escape key
2 participants