Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make Wshadow default #286

Open
kaihowl opened this issue Dec 20, 2013 · 2 comments
Open

Make Wshadow default #286

kaihowl opened this issue Dec 20, 2013 · 2 comments

Comments

@kaihowl
Copy link
Contributor

kaihowl commented Dec 20, 2013

I move to activate Wshadow as a default CPPFLAG. Any opinions?
@bastih
Copy link
Contributor

bastih commented Dec 20, 2013

-Wshadow crashes on gcc-4.7 in one of our external dependencies.

@kaihowl
Copy link
Contributor Author

kaihowl commented Dec 20, 2013

Weird. I just ran it in gcc-4.7 and it worked fine. It sure complains about what() in backwards-lib, but it does not crash.

On Dec 20, 2013, at 2:25 PM, Sebastian Hillig [email protected] wrote:

-Wshadow crashes on gcc-4.7 in one of our external dependencies.

—
Reply to this email directly or view it on GitHub.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bastih @kaihowl