Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Store::isVisibleForTransaction is misleading #343

Open
mrks opened this issue Apr 7, 2014 · 3 comments
Open

Store::isVisibleForTransaction is misleading #343

mrks opened this issue Apr 7, 2014 · 3 comments

Comments

@mrks
Copy link
Member

mrks commented Apr 7, 2014

Store::isVisibleForTransaction does not check if a row has been deleted by a transaction. While ValidatePositions does a check based on the modification list, a user might assume that isVisibleForTransaction is also covering that case.
@bastih
Copy link
Contributor

bastih commented Apr 7, 2014

Suggestion? Add a comment regarding this? I'll also take naming suggestions.

@mrks
Copy link
Member Author

mrks commented Apr 7, 2014

Correct me if I'm mistaken, but can't we cover that case by simply negating the result of the CID checks if tidVector[row] == tid?

@bastih
Copy link
Contributor

bastih commented Apr 7, 2014

That method used to be way better documented than it is right now. I'll check that in the morning.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bastih @mrks