Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Magento 2.3.x and below doesn't support anonymous classes #47

Open
indefinitedevil opened this issue May 17, 2021 · 1 comment
Open
Labels
bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed

Comments

@indefinitedevil
Copy link

Fixed in magento/magento2@e165d99#diff-eac375a5ebf2447976201de8fbe0bd0d04ce9798bc0e49c573e8d755317dac22

Basically, as it stands, the DI compiler for versions below 2.4.0-p1 doesn't support anonymous classes and so any compilation which uses Hyva Admin will fail due to the anonymous classes used in the factory models.

@Vinai
Copy link
Collaborator

Vinai commented May 19, 2021

Thanks for bringing this up, @indefinitedevil
I'd be willing to merge a PR that extracts all anonymous classes into named classes, but at the moment I don't have time to do it myself at the moment.
My first priority in my open source time is to get admin forms support working.
After that I would circle around to this issue if no one has beaten me to it by then.

@Vinai Vinai added bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed labels May 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants