-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Accept Enterkey to search from homepage #243
Comments
Additional: Steps to recreate:
Result:
Expected result:
Setting focus to this field would improve the user experience, and reduce the time needed to search for a train. |
Second problem can probably be fixed with an |
First problem can probably be fixed by using a Angular allows form tags, so there is no obvious reason to not use them. https://docs.angularjs.org/guide/forms. I can fix them myself this weekend when I have the time, if someone has some spare time before then they should feel free to pick it up :) Edit:
Changing Given the fact that this javascript hook is already present, this might be the best solution in this case. I'd like a contributor backing this up before I propose this in a pull request though. |
I'm not a front-end expert here myself so wouldn't know whether this actually would indeed fix the problem. @xavez maybe you can take a look at this latest comment? |
What @Bertware suggests (focus to click) is indeed a fast solution that doesn't require that much change. I agree that it should change to |
When entering 2 stations at the homepage search (https://irail.be/route) and pressing Enter, nothing happens.
Steps to recreate:
Result:
Expected result:
Handling this keypress would improve keyboard navigation on the site
The text was updated successfully, but these errors were encountered: