Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing script loading #20

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

Jaovitosr
Copy link

Pull Request Description

Problem

The manifest.json files were only loaded the first time the GitHub page was loaded, requiring a refresh every time a link requiring JavaScript loading was accessed.

Solution

Create a listener that identifies the requests made and, based on them, dynamically injects the requested script in real-time.

Changes Made

  • Implemented the listener mechanism to track requests dynamically.
  • Modified the code to inject the required script in real-time.
  • Ensured that manifest.json files are now loaded appropriately on subsequent requests without requiring a page refresh.

Tests Performed

  • Conducted testing to verify that manifest.json files are loaded correctly on initial page load.
  • Tested scenarios where JavaScript-loaded links are accessed to ensure dynamic script injection is functioning as intended.

@shbonita shbonita requested a review from KangilPark December 12, 2023 19:03
Copy link
Contributor

@KangilPark KangilPark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes do not appear to record gazes in the current version of Chrome.

  • Does iTrace-Chrome still record gazes on your end?
  • What websites did you use to test your changes? Do you have links to the exact pages you used for testing?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants