Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Toolbar no longer supports onItemExecuted callback #1234

Open
wilmaier opened this issue Feb 25, 2025 · 0 comments
Open

Toolbar no longer supports onItemExecuted callback #1234

wilmaier opened this issue Feb 25, 2025 · 0 comments
Assignees
Labels
breaking-change bug Something isn't working

Comments

@wilmaier
Copy link

wilmaier commented Feb 25, 2025

Describe the bug

It appears with appui 5.x the Toolbar was reworked and no longer makes a callback to the onItemExecuted prop when a toolbar button is clicked.

To Reproduce

Open any QA-based iModel containing sheets/drawings with hypermodel links.
Go to 2D Views widget.
Enable hypermodeling.
Hover over one of the icons that appears in the view.
Try to click any of the contextual toolbar buttons.
Notice that non of them work, as action put behind them is not invoked.

Expected Behavior

The onItemExecuted callback should be called after the clicked Toolbar item is executed.

Screenshots

Image

Desktop (please complete the applicable information)

No response

Additional context

No response

@wilmaier wilmaier added breaking-change bug Something isn't working labels Feb 25, 2025
@GerardasB GerardasB self-assigned this Feb 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking-change bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants