Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to v3 of oidc-client-ts #246

Open
ben-polinsky opened this issue May 9, 2024 · 1 comment
Open

Upgrade to v3 of oidc-client-ts #246

ben-polinsky opened this issue May 9, 2024 · 1 comment
Labels
breaking change good first issue Good for newcomers
Milestone
Core 5.x

Comments

@ben-polinsky
Copy link
Collaborator

https://github.com/authts/oidc-client-ts/blob/main/docs/migration.md
@ben-polinsky ben-polinsky added the good first issue Good for newcomers label May 9, 2024
@ben-polinsky ben-polinsky mentioned this issue Jun 18, 2024
Merged
@ben-polinsky
Copy link
Collaborator Author

ben-polinsky commented Jun 18, 2024 •
edited
Loading

This is a breaking change for signin-tool because users on < node 18 will have to add a polyfil for crypto.
Edit: yes we could add it, but the browserify-crypto package has not been updated in 7 years and node automatically adds crypto to globalThis.

Edit 2: node 18 is in maintenance anyway

@ben-polinsky ben-polinsky mentioned this issue Jun 18, 2024
Closed
@ben-polinsky ben-polinsky added this to the Core 5.x milestone Jun 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
breaking change good first issue Good for newcomers
Projects
None yet
Milestone
Core 5.x
Development

Successfully merging a pull request may close this issue.

node 20; oidc-ts-client 3.x; remove itwin- 3.x packages iTwin/auth-clients
1 participant
@ben-polinsky