node 20; oidc-ts-client 3.x; remove itwin- 3.x packages #251
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ben-polinsky
requested review from
calebmshafer,
evelynpreslar-bentley,
aruniverse,
anmolshres98 and
MichaelSwigerAtBentley
as code owners
aruniverse
reviewed
Jun 18, 2024
| @@ -56,6 +56,6 @@ | |||
| "typescript": "~5.3.3" | |||
| }, | |||
| "peerDependencies": { | |||
| "@itwin/core-bentley": "^3.3.0 || ^4.0.0" | |||
| "@itwin/core-bentley": "^4.0.0" | |||
There was a problem hiding this comment.
are we going to make this a major bump?
There was a problem hiding this comment.
Yep that is the idea
aruniverse
reviewed
Jun 18, 2024
| "@itwin/core-bentley": "^3.7.0", | ||
| "@itwin/eslint-plugin": "^4.0.2", | ||
| "@itwin/build-tools": "^4.7.1", | ||
| "@itwin/core-bentley": "^4.7.1", |
There was a problem hiding this comment.
does core-bentley need to be in lockstep with the other core pkgs?
There was a problem hiding this comment.
Are you suggesting they should both be 4.7.0? Thought for dev deps our policy was to bump to latest compatible with deps.
|
Don't know that it's worth moving to pure esm until core is there... |
After discussion with @aruniverse, we'll pick this back up closer to core@5 release. We'll go full ESM at that point as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cryptotoglobalThis.closes: #246