Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Presentation: Improve exceptional RPC responses #7562

Open
grigasp opened this issue Jan 16, 2025 · 1 comment
Open

Presentation: Improve exceptional RPC responses #7562

grigasp opened this issue Jan 16, 2025 · 1 comment
Labels
enhancement New feature or request presentation Issues related to presentation library
Milestone

Comments

@grigasp
Copy link
Member

grigasp commented Jan 16, 2025

At the moment PresentationRpcImpl uses its own system to handle majority of exceptional cases:

  • When a timeout occurs, it returns a specific HTTP 200 response, which tells the frontend to repeat the request. Instead, a proper HTTP response should be sent (408?)

  • When a request processing error occurs, e.g. a bad argument or something like that, it returns an HTTP 200 response containing the error message. Instead, we should probably return HTTP 400.

@grigasp grigasp added this to the iTwin.js 5.0 milestone Jan 16, 2025
@grigasp grigasp added enhancement New feature or request presentation Issues related to presentation library labels Jan 16, 2025
@aruniverse
Copy link
Member

Fyi @paulius-valiunas @GytisCepk

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request presentation Issues related to presentation library
Projects
None yet
Development

No branches or pull requests

2 participants