Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error during undo operation #84

Open
hasanbalci opened this issue Sep 3, 2019 · 4 comments
Open

Error during undo operation #84

hasanbalci opened this issue Sep 3, 2019 · 4 comments
Labels
bug Something isn't working

Comments

@hasanbalci
Copy link
Contributor

If there is a collapsed node in the graph and we call collapseAll function, then undo operation throws error. It can be produced in undoable demo.

@hasanbalci hasanbalci added the bug Something isn't working label Sep 3, 2019
@hasanbalci
Copy link
Contributor Author

The bug is also valid for collapseRecursively function. If there are two nested compound nodes and the one inside the other is collapsed, then if we either call collapseAll function or collapseRecursively function on the outer compound node, undo operation throws error.

@ugurdogrusoz
Copy link
Contributor

@hasanbalci please leave a comment here on how we plan to fix this in a future release and unassign yourself.

@hasanbalci
Copy link
Contributor Author

The bug may be fixed by providing an option to the expandRecursively and collapseRecursively functions to control the level that the recursion will continue or the nodes that will be affected.

@hasanbalci hasanbalci removed their assignment Sep 12, 2019
@hasanbalci
Copy link
Contributor Author

I think this was automatically closed long before, so I am opening it again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants