Unexpected behavior on loading sample data

[hasanbalci]

• In collaborative mode, if "Load Sample Data" is clicked, seven unit of data are shown in Data Set(s):

• Another unexpected behavior I observed (independent from mode) is that after loading some alteration data to a gene from cBioPortal, if "Load Sample Data" is clicked, more than six units of data are shown both in Data Set(s) and gene:

[YusufZiyaOzgul]

@hasanbalci
There is another problem.
For the collaborative mode,
the screen of client 1 and client 2 are same at the beginning

After client 1 selected the ovarian cancer( right one) on the screen, both of the ovarian cancers enabled.

However, client 2 see that the ovarian cancer ( left one ) selected.

[YusufZiyaOzgul]

Another problem may be that described below.

At the beginning five units are selected.

When I clicked the breast cancer ( bottom ), other breast cancer is also selected( triggered).

Since it activated 2 breast cancer with one click, the number of data samples increased from 5 to 7. So, there is a issue, more than 6 data unit are shown.

When I tried to close the breast cancer( whose activation is triggered by other in the above example), it does not close.

[ugurdogrusoz]

@msalihaltun Should we force data set names to be unique to avoid some of these situations?

[msalihaltun]

I thought we actually checked for already existing data while loading, and we do, but we do that only for cBioPortal data. So multiple sample experiment data can actually be loaded. We use a different data flow to load experiment data compared to cBioPortal data. I'm gonna try to figure out a way to make sure:

1. We do not load multiple sample experiment data.
2. We do not exceed the limit of 6 data sets while loading sample data or data from file.

Ideally there would be a common path in code where data would flow through for cases like this.

[msalihaltun]

I disabled adding multiple sample data. Also the collaborative mode should properly respect the limit of 6 data sets shown.

[ugurdogrusoz]

Works well in general but I still see some edge case problems:

• Open a map
• Load a data set
• Load sample data
• Remove all data
• Load a data set
• Load sample data. We see 4 data sets in the dialog but the map renders more than 4 (a Resize to content will not help):
  

[ugurdogrusoz]

Looks good to me. @hasanbalci @YusufZiyaOzgul please test and remove your assignment if OK.

[YusufZiyaOzgul]

There may be a another problem.

At the beginning I imported LUSC-2012-Notch-signaling-pathway and I fetched Acute Myeloid Leukemia (OHSU, Nature 2018) and Thymoma (TCGA, PanCancer Atlas).

Then I imported LUAD-2014-Oxidative-stress-response-pathway using TCGA.
However, datas from the previous pathway still shown(activated) in data set but there is no information about them on the new pathway.

I tried to deactivate and reactivate them on data set but still none of them shown on pathway.

Then, I fetched Cholangiocarcinoma (TCGA, PanCancer Atlas).

After that, data sets activated from previous pathway are shown on this pathway but they are shown gray .

Finally, I removed all data sets and I re-fetched them and I got different result.

I could not find the case which exceeds maximum number of activated data sets any time = 6 and all of the data sets have unique names.

[msalihaltun]

I believe this is intended, a known issue and related to #114.

[ugurdogrusoz]

Yes, this is a known issue. We only keep the data of a gene if that gene is currently in the map.