Fix iOS 17 crash related to SplitViewController (#96)

iZettle · Jan 29, 2024 · 0ef9f76 · 0ef9f76
1 parent ebd1e68
commit 0ef9f76
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 0 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,3 +1,6 @@
+# 1.16.0
+- Fix split view crash for iOS 17
+
 # 1.15.3
 - Support Xcode 15
 

diff --git a/Presentation/UINavigationController+Presenting.swift b/Presentation/UINavigationController+Presenting.swift
@@ -245,6 +245,11 @@ private extension UINavigationController {
 extension UINavigationController {
     func transferViewControllers(from: UINavigationController) {
         viewControllers += from.viewControllers
+        /*
+         This line helps us prevent a crash that appeared with iOS 17. Explanation of the crash can
+         be found here https://stackoverflow.com/questions/77228311/nsinternalinconsistencyexception-reason-layout-requested-for-visible-naviga
+         */
+        from.viewControllers = []
         for pushPoper in from.popSignalPushPopers.compactMap({ $0.value }) {
             let onComplete = pushPoper._onComplete
             pushPoper.bag.dispose()