-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue 28- Material Menu (List) Page and pdfViewer Page #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
12henbx
changed the title
Issue 28 material pdf
Issue 28- Material Menu Page and pdfViewer Page
Oct 23, 2023
12henbx
changed the title
Issue 28- Material Menu Page and pdfViewer Page
Issue 28- Material Menu (List) Page and pdfViewer Page
Oct 23, 2023
This was
linked to
issues
Oct 23, 2023
atnanahidiw
requested changes
Oct 23, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
use Tab
, please 🙏
later, we will have more items for the list (not only 2016, 2017, 2018)
so a checkbox in the bottom looks like out of place
app/lib/features/material/viewer/presentation/pages/pdf_viewer_page.dart
Show resolved
Hide resolved
atnanahidiw
approved these changes
Oct 24, 2023
app/lib/features/material/menu/presentation/pages/material_menu.dart
Outdated
Show resolved
Hide resolved
…u.dart Edit title list text Co-authored-by: Mirza Widihananta <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
From Task
Proposed Changes