Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] pino and rxjs should be peer dependencies of nestjs-pino #1148

Closed
alexedwardjones opened this issue Sep 28, 2022 · 1 comment
Closed
Assignees
Labels
bug Something isn't working

Comments

@alexedwardjones
Copy link

alexedwardjones commented Sep 28, 2022

[x] I've read the docs of nestjs-pino

[x] I've read the docs of pino

[x] I couldn't find the same open issue of nestjs-pino

What is the current behavior?

I'm using yarn pnp which is pretty strict when it comes to libraries and their dependencies. I'm getting the below errors when trying to run an app using nestjs-pino.

Error: nestjs-pino tried to access pino, but it isn't declared in its dependencies; this makes the require call ambiguous and unsound.
Error: nestjs-pino tried to access rxjs, but it isn't declared in its dependencies; this makes the require call ambiguous and unsound.

I think adding pino and rxjs to the peerDependencies might be the fix.

A temporary workaround is to add the below to .yarnrc.yml.

packageExtensions:
  "nestjs-pino@*":
    peerDependencies:
      "pino": "*"
      "rxjs": "*"

What is the expected behavior?

No error.

@alexedwardjones alexedwardjones added the bug Something isn't working label Sep 28, 2022
@alexedwardjones alexedwardjones changed the title [BUG] Pino should be a peer dependency of nestjs-pino [BUG] pino and rxjs should be peer dependencies of nestjs-pino Sep 28, 2022
@iamolegga
Copy link
Owner

duplicate of older issue #1004 , will rename that to more general

@iamolegga iamolegga closed this as not planned Won't fix, can't repro, duplicate, stale Jan 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants