Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add routes for different parts of game #177

Open
ianjmacintosh opened this issue Mar 30, 2021 · 1 comment · May be fixed by #187
Open

Add routes for different parts of game #177

ianjmacintosh opened this issue Mar 30, 2021 · 1 comment · May be fixed by #187
Assignees

Comments

@ianjmacintosh
Copy link
Owner

ianjmacintosh commented Mar 30, 2021

Path Role
/ Main menu
/play Active game
/credits Credits page
/instructions Instructions screen
@ianjmacintosh
Copy link
Owner Author

I've made the routes, but moving components to get served from those routes instead of from a monolithic App page is a bigger ask.

Questions:

  • What components match with each route? i.e., / is the main menu, which I think comes from a giant specially-styled Alert containing a Menu
  • What props do those components currently inherit from App? Migrating them will be as big or small as that task is

I think making a separate task for building each route would improve my estimate accuracy and help me plan better

@ianjmacintosh ianjmacintosh linked a pull request Apr 13, 2021 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant