Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Use runeio library. #992

Merged
merged 2 commits into from
Nov 3, 2023
Merged

Conversation

ianlewis
Copy link
Owner

@ianlewis ianlewis commented Nov 3, 2023

The runes package was externalized in the runeio module. Use that as a dependency.

Description:

The generic runes package can be better maintained as a separate module.

Related Issues:

Fixes #973

Checklist:

  • Review the CONTRIBUTING.md documentation.
  • Add a reference to a related issue in the repository.
  • Add a description of the changes proposed in the pull request.
  • Add unit tests if applicable.
  • Add a note in the CHANGELOG.md if applicable.
  • Sign the Google CLA.

The `runes` package was externalized in the `runeio` module. Use that as
a dependency.

Fixes #973

Signed-off-by: Ian Lewis <[email protected]>
@ianlewis ianlewis linked an issue Nov 3, 2023 that may be closed by this pull request
@ianlewis ianlewis marked this pull request as ready for review November 3, 2023 01:47
Copy link

codecov bot commented Nov 3, 2023

Codecov Report

Merging #992 (b817cf2) into main (146d57d) will decrease coverage by 0.54%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #992      +/-   ##
==========================================
- Coverage   82.14%   81.61%   -0.54%     
==========================================
  Files          19       18       -1     
  Lines        1126     1050      -76     
  Branches       14       14              
==========================================
- Hits          925      857      -68     
+ Misses        146      140       -6     
+ Partials       55       53       -2     
Files Coverage Δ
internal/scanner/scanner.go 78.15% <100.00%> (ø)

Signed-off-by: Ian Lewis <[email protected]>
@ianlewis ianlewis merged commit cc2ab6a into main Nov 3, 2023
26 checks passed
@ianlewis ianlewis deleted the 973-refactor-use-runeio-library branch November 3, 2023 02:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[refactor] Use runeio library
1 participant