Multi Byte Characters cause flat file definitions to shift #52
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In current state, if you have a file that contain multi-byte characters (for example, em dash, accented characters, etc). The unmarshal moves the characters over x positions depending on the bytes. This causes some values from other fields to not be in the correct struct field.
This PR will change the string unmarshal to convert to a rune before picking the start and end positions and select full characters instead of bytes.