Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix contenteditalbe firefox table selection #5491

Conversation

WcaleNieWolny
Copy link
Contributor

Description
This PR fixes the contenteditable table selection in firefox. Firefox uses a custom editor when table is contenteditable and this adds support for this custom editor.

Issue
Fixes: None, but it does fix this

Example

2023-07-30.08-34-11.mp4

Before this PR it threw some exception IIRC

Context
Firefox basically uses rows in the contenteditable table selection and startOffset is the cell offset. By walking down the DOM tree we can get the sames values as in chrome. I also added some checks to make sure this does not crash.

Checks

  • The new code matches the existing patterns and styles.
  • The tests pass with yarn test.
  • The linter passes with yarn lint. (Fix errors with yarn fix.)
  • The relevant examples still work. (Run examples with yarn start.)
  • You've added a changeset if changing functionality. (Add one with yarn changeset add.)

@changeset-bot
Copy link

changeset-bot bot commented Jul 30, 2023

🦋 Changeset detected

Latest commit: 55b3b60

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
slate-react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@dylans dylans merged commit a5576e5 into ianstormtaylor:main Jul 31, 2023
@github-actions github-actions bot mentioned this pull request Jul 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants