Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Budgets calc by day rate #17

Merged
merged 14 commits into from
Nov 8, 2023
Merged

Budgets calc by day rate #17

merged 14 commits into from
Nov 8, 2023

Conversation

simon-20
Copy link
Contributor

@simon-20 simon-20 commented Oct 3, 2023

Resolves #16

@simon-20 simon-20 requested a review from markbrough October 3, 2023 10:29
@simon-20 simon-20 requested a review from markbrough November 7, 2023 16:24
markbrough
markbrough approved these changes Nov 7, 2023
View reviewed changes
Copy link
Contributor

@markbrough markbrough left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! Thank you.

@simon-20 simon-20 merged commit c8f0c0b into iati-data-access:main Nov 8, 2023
@simon-20 simon-20 deleted the budgets_calc_by_day_rate branch November 8, 2023 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markbrough markbrough markbrough approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Budgets should be calculated using a daily-rate, then aggregated back up
2 participants
@simon-20 @markbrough