Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix AbstractCriterionQuery phpdoc #9

Merged
merged 4 commits into from
Jan 16, 2025
Merged

Fix AbstractCriterionQuery phpdoc #9

merged 4 commits into from
Jan 16, 2025

Conversation

adriendupuis
Copy link
Contributor

🎫 Issue IBX-XXXXX

Description:

Issue: PHP API Reference for this class quotes non-existing TCriterion and TSortClause classes.
https://doc.ibexa.co/en/latest/api/php_api/php_api_reference/classes/Ibexa-Contracts-ProductCatalog-Values-Catalog-CatalogQuery.html#methods

Fixes:

  • Add phpstan- prefix to tags using those template.
  • Add a standard tag for array key and value types.

Note: Maybe some phpstan- tags are useless because semantically declaring the same thing than the standard one.

For QA:

Documentation:

PHP API Reference is regenerated at each new release.

@adamwojs adamwojs merged commit 0c043ca into 4.6 Jan 16, 2025
9 checks passed
@adamwojs adamwojs deleted the fix-phpdoc branch January 16, 2025 10:40
@adamwojs
Copy link
Member

Could you please merge it up @adriendupuis ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants