From b9f1582decca99f6b3e9f4ed83f21daac00ac3c4 Mon Sep 17 00:00:00 2001
From: Mikolaj Adamczyk <mikolaj.adamczyk@ez.no>
Date: Mon, 16 Sep 2024 13:02:57 +0200
Subject: [PATCH] Aligned PHPStan baseline and updated Symfony deprecations
 helper setting (#426)

For more details see https://github.com/ibexa/core/pull/426

Key changes:

* Fixed PHPStan issue

* [Tests] Increased max deprecation number after Symfony release

---------

Co-authored-by: Andrew Longosz <alongosz@users.noreply.github.com>
---
 phpstan-baseline-gte-8.0.neon |  2 +-
 phpstan-baseline.neon         | 15 ---------------
 phpunit.xml                   |  2 +-
 3 files changed, 2 insertions(+), 17 deletions(-)

diff --git a/phpstan-baseline-gte-8.0.neon b/phpstan-baseline-gte-8.0.neon
index c3cde9014c..3130a18ada 100644
--- a/phpstan-baseline-gte-8.0.neon
+++ b/phpstan-baseline-gte-8.0.neon
@@ -71,7 +71,7 @@ parameters:
 			path: src/bundle/Core/Imagine/IORepositoryResolver.php
 
 		-
-			message: "#^Method Ibexa\\\\Bundle\\\\Core\\\\URLChecker\\\\Handler\\\\HTTPHandler\\:\\:createCurlHandlerForUrl\\(\\) should return resource but returns CurlHandle\\.$#"
+			message: "#^Method Ibexa\\\\Bundle\\\\Core\\\\URLChecker\\\\Handler\\\\HTTPHandler\\:\\:createCurlHandlerForUrl\\(\\) should return resource but returns \\(CurlHandle\\|false\\)\\.$#"
 			count: 1
 			path: src/bundle/Core/URLChecker/Handler/HTTPHandler.php
 
diff --git a/phpstan-baseline.neon b/phpstan-baseline.neon
index bda707eb66..6c2db188d9 100644
--- a/phpstan-baseline.neon
+++ b/phpstan-baseline.neon
@@ -9675,11 +9675,6 @@ parameters:
 			count: 2
 			path: src/lib/FieldType/Keyword/KeywordStorage/Gateway/DoctrineStorage.php
 
-		-
-			message: "#^Cannot call method fetchFirstColumn\\(\\) on Doctrine\\\\DBAL\\\\ForwardCompatibility\\\\Result\\|int\\|string\\.$#"
-			count: 1
-			path: src/lib/FieldType/Keyword/KeywordStorage/Gateway/DoctrineStorage.php
-
 		-
 			message: "#^Method Ibexa\\\\Core\\\\FieldType\\\\Keyword\\\\KeywordStorage\\\\Gateway\\\\DoctrineStorage\\:\\:assignKeywords\\(\\) has parameter \\$keywordMap with no value type specified in iterable type array\\.$#"
 			count: 1
@@ -10275,11 +10270,6 @@ parameters:
 			count: 3
 			path: src/lib/FieldType/Url/UrlStorage/Gateway/DoctrineStorage.php
 
-		-
-			message: "#^Cannot call method fetchFirstColumn\\(\\) on Doctrine\\\\DBAL\\\\ForwardCompatibility\\\\Result\\|int\\|string\\.$#"
-			count: 1
-			path: src/lib/FieldType/Url/UrlStorage/Gateway/DoctrineStorage.php
-
 		-
 			message: "#^Method Ibexa\\\\Core\\\\FieldType\\\\Url\\\\UrlStorage\\\\Gateway\\\\DoctrineStorage\\:\\:getIdUrlMap\\(\\) return type has no value type specified in iterable type array\\.$#"
 			count: 1
@@ -16430,11 +16420,6 @@ parameters:
 			count: 12
 			path: src/lib/Persistence/Legacy/Content/Location/Gateway/DoctrineDatabase.php
 
-		-
-			message: "#^Cannot call method fetchFirstColumn\\(\\) on Doctrine\\\\DBAL\\\\ForwardCompatibility\\\\Result\\|int\\|string\\.$#"
-			count: 1
-			path: src/lib/Persistence/Legacy/Content/Location/Gateway/DoctrineDatabase.php
-
 		-
 			message: "#^Method Ibexa\\\\Core\\\\Persistence\\\\Legacy\\\\Content\\\\Location\\\\Gateway\\\\DoctrineDatabase\\:\\:addSort\\(\\) has parameter \\$languageSettings with no value type specified in iterable type array\\.$#"
 			count: 1
diff --git a/phpunit.xml b/phpunit.xml
index b55dae9d52..cb60d982af 100644
--- a/phpunit.xml
+++ b/phpunit.xml
@@ -11,7 +11,7 @@
   >
   <php>
     <ini name="error_reporting" value="-1" />
-    <env name="SYMFONY_DEPRECATIONS_HELPER" value="max[total]=576&amp;verbose=0"/>
+    <env name="SYMFONY_DEPRECATIONS_HELPER" value="max[total]=631&amp;verbose=0"/>
   </php>
   <testsuites>
     <testsuite name="unit_core">