suggestions from code review

ibexa · Dec 11, 2024 · e9b8362 · e9b8362
1 parent f420587
commit e9b8362
Showing 1 changed file with 6 additions and 8 deletions.
diff --git a/src/bundle/Core/Command/ReindexCommand.php b/src/bundle/Core/Command/ReindexCommand.php
@@ -450,17 +450,15 @@ private function getPhpPath()
     private function getNumberOfCPUCores()
     {
         $cores = 1;
-        if (isset($_SERVER['PLATFORM_BRANCH']) && is_file('/run/config.json')) {
+        if (isset($_SERVER['PLATFORM_BRANCH']) && is_readable('/run/config.json')) {
             // Ibexa Cloud: read #cpus from config
-            $config_json_encoded = file_get_contents('/run/config.json');
-            if ($config_json_encoded == false) {
+            $configJsonEncoded = file_get_contents('/run/config.json');
+            if ($configJsonEncoded === false) {
                 return 1;
             }
-            $config_json = json_decode($config_json_encoded);
-            $cores = isset($config_json->info->limits->cpu) ? max(1, floor($config_json->info->limits->cpu)) : 1;
-
-            return (int)$cores;
-        } elseif (is_file('/proc/cpuinfo')) {
+            $configJson = json_decode($configJsonEncoded);
+            $cores = isset($configJson->info->limits->cpu) ? max(1, (int) ($configJson->info->limits->cpu)) : 1;
+        } elseif (is_readable('/proc/cpuinfo')) {
             // Linux (and potentially Windows with linux sub systems)
             $cpuinfo = file_get_contents('/proc/cpuinfo');
             preg_match_all('/^processor/m', $cpuinfo, $matches);