After CR

ibexa · Sep 10, 2024 · 214f84d · 214f84d
1 parent 17641ee
commit 214f84d
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 9 deletions.
diff --git a/src/bundle/Resources/public/js/CKEditor/custom-tags/block-custom-tag/custom-tag-ui.js b/src/bundle/Resources/public/js/CKEditor/custom-tags/block-custom-tag/custom-tag-ui.js
@@ -221,13 +221,12 @@ class IbexaCustomTagUI extends Plugin {
 
     setPanelContentMaxHeight() {
         const { innerHeight: windowHeight } = window;
-        const { top: panelTopPosition } = this.balloon.view;
-        const { element: panelNode } = this.balloon.view;
+        const { top: panelTopPosition, element: panelNode } = this.balloon.view;
         const panelHeader = panelNode.querySelector('.ibexa-custom-tag-panel-header');
         const panelContent = panelNode.querySelector('.ibexa-custom-tag-panel-content');
         const panelFooter = panelNode.querySelector('.ibexa-custom-tag-panel-footer');
-        const panelHeaderHeight = panelHeader?.offsetHeight || 0;
-        const panelFooterHeight = panelFooter?.offsetHeight || 0;
+        const panelHeaderHeight = panelHeader?.offsetHeight ?? 0;
+        const panelFooterHeight = panelFooter?.offsetHeight ?? 0;
         const isPanelOverTopWindowEdge = panelTopPosition < 0;
         const maxHeightValue = isPanelOverTopWindowEdge
             ? panelContent.offsetHeight - Math.abs(panelTopPosition)

diff --git a/...bundle/Resources/public/js/CKEditor/custom-tags/inline-custom-tag/inline-custom-tag-ui.js b/...bundle/Resources/public/js/CKEditor/custom-tags/inline-custom-tag/inline-custom-tag-ui.js
@@ -118,13 +118,12 @@ class IbexaInlineCustomTagUI extends Plugin {
 
     setPanelContentMaxHeight() {
         const { innerHeight: windowHeight } = window;
-        const { top: panelTopPosition } = this.balloon.view;
-        const { element: panelNode } = this.balloon.view;
+        const { top: panelTopPosition, element: panelNode } = this.balloon.view;
         const panelHeader = panelNode.querySelector('.ibexa-custom-tag-panel-header');
         const panelContent = panelNode.querySelector('.ibexa-custom-tag-panel-content');
         const panelFooter = panelNode.querySelector('.ibexa-custom-tag-panel-footer');
-        const panelHeaderHeight = panelHeader?.offsetHeight || 0;
-        const panelFooterHeight = panelFooter?.offsetHeight || 0;
+        const panelHeaderHeight = panelHeader?.offsetHeight ?? 0;
+        const panelFooterHeight = panelFooter?.offsetHeight ?? 0;
         const isPanelOverTopWindowEdge = panelTopPosition < 0;
         const maxHeightValue = isPanelOverTopWindowEdge
             ? panelContent.offsetHeight - Math.abs(panelTopPosition)

diff --git a/src/bundle/Resources/public/scss/_balloon-form.scss b/src/bundle/Resources/public/scss/_balloon-form.scss
@@ -11,7 +11,6 @@
 
         &__fields {
             overflow: auto;
-
             padding: calculateRem(8px) calculateRem(16px);
 
             &--attributes {