Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(cors): enable cors/options preflight for all API routes #22

Closed
landonreed opened this issue Dec 10, 2018 · 3 comments
Closed

feat(cors): enable cors/options preflight for all API routes #22

landonreed opened this issue Dec 10, 2018 · 3 comments
Labels
imported

Comments

@landonreed
Copy link
Contributor

Issue by landonreed
Tuesday Apr 04, 2017 at 15:20 GMT
Originally opened as catalogueglobal#5

@zbouziane here's an update for cors to fix #2.

This adds config properties to customize the cors origins, headers, and methods. It also adds SparkUtils.enableCors and cleans up some lingering code in DataManager.

landonreed included the following code: https://github.com/catalogueglobal/datatools-server/pull/5/commits
@landonreed
Copy link
Contributor Author

Comment by landonreed
Tuesday May 02, 2017 at 12:28 GMT

@zbouziane could you take a look at this PR and let me know if it solves your issue with CORS.

@landonreed
Copy link
Contributor Author

Comment by landonreed
Monday Aug 28, 2017 at 11:00 GMT

@zbouziane, is this still something you all need? Thanks.

@landonreed
Copy link
Contributor Author

Comment by landonreed
Wednesday Oct 10, 2018 at 20:42 GMT

Closing this PR due to inaction.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
imported
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@landonreed