Skip to content
This repository was archived by the owner on Jan 17, 2025. It is now read-only.

This runtime should not include a copy of the nodejs proxy server #121

Closed
csantanapr opened this issue Jun 28, 2018 · 1 comment
Closed

Comments

@csantanapr
Copy link
Contributor

This runtime should not have a copy of the OpenWhisk proxy server.

Options:

  1. We could extend the image from OpenWhisk nodejs 8 in the Dockerfile
FROM openwhisk/action-nodejs-v8:1.5.0
....
  1. Fetch in the Dockerfile the app.js, runner.js and src/service.js from https://github.com/apache/incubator-openwhisk-runtime-nodejs/tree/master/core/nodejsActionBase
    like the OpenWhisk python runtime does for the proxy https://github.com/apache/incubator-openwhisk-runtime-python/blob/master/core/python2Action/Dockerfile#L53

I think I preferred option 1.

cc @eweiter

@csantanapr
Copy link
Contributor Author

This is already done

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

No branches or pull requests

1 participant