Skip to content
This repository was archived by the owner on Jan 17, 2025. It is now read-only.

Remove all dependencies from main repo openwhisk for unit tests #24

Closed
csantanapr opened this issue Sep 21, 2017 · 2 comments
Closed

Remove all dependencies from main repo openwhisk for unit tests #24

csantanapr opened this issue Sep 21, 2017 · 2 comments
Assignees

Comments

@csantanapr
Copy link
Contributor

No description provided.

@csantanapr csantanapr self-assigned this Sep 21, 2017
@csantanapr
Copy link
Contributor Author

csantanapr commented Sep 22, 2017

This is going to take more work and discussion to do.

Some classes and functions are easy to duplicate.

The problems with https://github.com/apache/incubator-openwhisk/blob/master/tests/src/test/scala/actionContainers/ActionContainer.scala#L167

 private def syncPost(host: String, port: Int, endPoint: String, content: JsValue): (Int, Option[JsObject]) = {
    whisk.core.containerpool.docker.HttpUtils.post(host, port, endPoint, content)
  }

The whisk.core.containerpool.docker.HttpUtils not quite easy to pull over, it has a lot of dependencies from main repo around entities and response are interpreted

@csantanapr
Copy link
Contributor Author

There are too many runtime repos, and is better to leverage common test code and pull via maven install

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

No branches or pull requests

1 participant