Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Guardian test in CI Workflow #32

Merged
merged 1 commit into from
Oct 21, 2024
Merged

Fix Guardian test in CI Workflow #32

merged 1 commit into from
Oct 21, 2024

Conversation

fayvor
Copy link
Contributor

@fayvor fayvor commented Oct 21, 2024

  • Fix path to Guardian/HAP

PR Checklist

  • Commits signed: All commits must be GPG or SSH signed.
  • DCO Compliance: Developer Certificate of Origin (DCO) applies to the code, documentation, and any example data provided. Ensure commits are signed off.
  • Notebook outputs cleared: Ensure all notebook outputs are cleared.
  • Automated testing: Add the recipe to the automated tests.
  • Test in Google Colab:
    • Test that it works in Google Colab (Python 3.10.12).
    • Colab has its own package set and Python version, so ensure compatibility.
  • Test locally:
    • Ensure the code works in a fresh Python virtual environment (venv).
  • Flexible LLM platform support:
    • The platform should be easily switchable. Use LangChain for now.
    • Include !pip install git+https://github.com/ibm-granite-community/granite-kitchen in the instructions.
  • Example data: Follow the example data guidance.
  • README.md updates:
    • Add a link to the recipe in the Table of Contents (ToC).
    • Include a Colab button after that link.

Signed-off-by: Fayvor Love <[email protected]>
@fayvor
Copy link
Contributor Author

fayvor commented Oct 21, 2024

The Agentic RAG test is failing.
This can also sometimes fail due to summaries exceeding the context window in Summarize, which is fixed with this PR.

@adampingel adampingel merged commit c46ae5f into main Oct 21, 2024
1 of 2 checks passed
@adampingel adampingel deleted the fix-guardian-tests branch October 21, 2024 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants