Use LDR_CNTRL on AIX to use 64KB pages and modify removeAixExpectedVars #749
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Abdulrahman Alattas <[email protected]>
6 tasks
keithc-ca
requested changes
Mar 8, 2024
There was a problem hiding this comment.
Checking for the options that control enablement of this need to be added (see eclipse-openj9/openj9#19052 (comment)).
Comment on lines
+315
to
+319
| const char * ldrCntrlName = "LDR_CNTRL"; | ||
| const char *ldrCntrlValue = "TEXTPSIZE=64K@DATAPSIZE=64K@STACKPSIZE=64K@SHMPSIZE=64K"; | ||
| if (setenv(ldrCntrlName, ldrCntrlValue, 0) != 0) { | ||
| fprintf(stderr, "setenv('LDR_CNTRL=TEXTPSIZE=64K@DATAPSIZE=64K@STACKPSIZE=64K@SHMPSIZE=64K') failed: performance may be affected\n"); | ||
| } |
There was a problem hiding this comment.
For consistency, please remove the space after * on line 315.
Also suggest adding this before setting LDR_CNTRL to keep things organized.
Comment on lines
-814
to
+816
| // OpenJ9 adds MALLOCOPTIONS | ||
| // OpenJ9 adds MALLOCOPTIONS and LDR_CNTRL | ||
| cleanedVars = cleanedVars.replace("MALLOCOPTIONS=multiheap,considersize,", ""); | ||
| cleanedVars = cleanedVars.replace("LDR_CNTRL=TEXTPSIZE=64K@DATAPSIZE=64K@STACKPSIZE=64K@SHMPSIZE=64K,", ""); |
There was a problem hiding this comment.
The method comment should be updated to list all three expected variables.
Likewise, the comment here should name and the code should remove the variables in alphabetic order (the sentence in the comment should end with a period).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can improve performance on AIX by setting LDR_CNTRL to use 64KB pages by default.
OpenJ9 Tracker: eclipse-openj9/openj9#19052