Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase tags' weight in solvePnP & Fix combine map util #7

Merged
merged 2 commits into from
Aug 26, 2024

Conversation

Petingo
Copy link
Collaborator

@Petingo Petingo commented Jul 28, 2024

  1. Increase the weight of tag in solvePnP
  2. Fix the utility executable tslam_combine_map.
    As the make install has some issues now. to use with AC's combine map function, please run ln to create a symbolic link to the compiled executable in the util folder.
sudo ln -sf /usr/local/bin/tslam_combine_map {tslam_build_folder}/utils/tslam_combine_map

@Petingo Petingo changed the title Fix: tslam combine map Increase tags' weight in solvePnP & Fix combine map util Jul 28, 2024
@9and3
Copy link
Contributor

9and3 commented Jul 29, 2024

@Petingo could you have a look to sort the CI fail before merging this plis? Thanks!

@9and3 9and3 added bug Something isn't working enhancement New feature or request labels Jul 29, 2024
@9and3
Copy link
Contributor

9and3 commented Aug 26, 2024

@Petingo please check if we need to merge this one! thanks!

Copy link
Contributor

@9and3 9and3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good as discussed!

@9and3 9and3 merged commit 4dd49bb into main Aug 26, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants