Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Long texts #108

Open
MortenHN81 opened this issue May 19, 2017 · 4 comments
Open

Long texts #108

MortenHN81 opened this issue May 19, 2017 · 4 comments

Comments

@MortenHN81
Copy link

Hi, i really love swiftyspinner and use it alot, there is very little it cannot do that i need.

But i would like it to support longer texts right now the text goes beyond the bounds of the animation circle, it would be nice if it would expand to hold all the text, or if it was possible to remove the circles so that it was possible to use the spinner as to give information on screen.

@icanzilb
Copy link
Owner

It sounds as if what you need is simply a label on a vibrant background? It might be simpler to just use a label instead of a spinner

@MortenHN81
Copy link
Author

Hi Thank you for your answer.

Yeah you might be right, i was just thinking as the swiftyspinner supports the static circles with text in the middle it kinda already supports this functionality. But it does not handle if the text is to large, so as the functionality is already half implemented i throught i would suggest it. I agree this is not a issue or a bug, its more like a feature request.

But besides my request i think the swiftyspinner handles long text porly by just lettting it go outside the circles, it looks bad, and when building apps with a lot of localization it can be hard to predict how long the texts would be.

a few suggestions on how the spinner could handle longer texts.

  1. make the circles larger at runtime to fit around the label and all the text
  2. change font so all text is inside the circles.
  3. remove circles if text is overlapping the circles.
  4. use core text to make text fit inside the circles insted of using square label.

I want to point out this is not critisisme its just a suggestion, i really love the swiftspinner its a really awesome module that i love to use, and are going to use alot more in the future :)

Best Regards
Morten

@icanzilb
Copy link
Owner

Sure, you make a very good point :) SwiftSpinner was designed to show, you know, a single word or so along the lines of Loading... or Connecting... that's why you have issues with "long texts". If you feel like helping refresh the library or just making a pr for "long text", we can talk more :)

@MortenHN81
Copy link
Author

I would love to help out in one way or another :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants