Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

auto-detect-theme depends on faulty version of dark-light #2581

Closed
4 tasks done
Rudxain opened this issue Sep 18, 2024 · 3 comments
Closed
4 tasks done

auto-detect-theme depends on faulty version of dark-light #2581

Rudxain opened this issue Sep 18, 2024 · 3 comments
Labels
bug Something isn't working

Comments

@Rudxain
Copy link

Rudxain commented Sep 18, 2024

Is your issue REALLY a bug?

  • My issue is indeed a bug!
  • I am not crazy! I will not fill out this form just to ask a question or request a feature. Pinky promise.

Is there an existing issue for this?

  • I have searched the existing issues.

Is this issue related to iced?

  • My hardware is compatible and my graphics drivers are up-to-date.

What happened?

(#2343) This line introduced a buggy feature: frewsxcv/rust-dark-light#39

TLDR: please use an exact version, preferably =1.0.0, as I've tested it works

What is the expected behavior?

It should detect color-scheme on any supported OS

Version

master

Operating System

Linux

Do you have any log output?

No response

@Rudxain Rudxain added the bug Something isn't working label Sep 18, 2024
@Mingun
Copy link

Mingun commented Sep 18, 2024

This is a library. If it would use exact dependencies, consumes cannot select other version. You should lock the version of the dependency in you application crate. If your crate is a library, please, do not use exact versions.

@Rudxain
Copy link
Author

Rudxain commented Sep 18, 2024

If it would use exact dependencies, consumes cannot select other version. You should lock the version of the dependency in you application crate. If your crate is a library, please, do not use exact versions.

Thanks for the advice! It reminded me of this (which I previously forgotten)

Should I close this issue?

@hecrj
Copy link
Member

hecrj commented Sep 18, 2024

As mentioned, this should be fixed upstream.

@hecrj hecrj closed this as completed Sep 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants