-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Transparent window does not work on master branch (regression from 0.13) #2727
Labels
bug
Something isn't working
Comments
I'm not sure but this looks related to the downgrade of winit crate.
|
I confirmed this. The following patch fixed this issue. Is there any reason to stick with winit 0.30.1? Or is it just out-dated? diff --git a/Cargo.toml b/Cargo.toml
index 9059cfd9..f51b3717 100644
--- a/Cargo.toml
+++ b/Cargo.toml
@@ -189,7 +189,8 @@ web-time = "1.1"
wgpu = "23.0"
winapi = "0.3"
window_clipboard = "0.4.1"
-winit = { git = "https://github.com/iced-rs/winit.git", rev = "254d6b3420ce4e674f516f7a2bd440665e05484d" }
+winit = "0.30"
[workspace.lints.rust]
rust_2018_idioms = { level = "forbid", priority = -1 }
diff --git a/winit/src/program.rs b/winit/src/program.rs
index 499c6252..3e04f52e 100644
--- a/winit/src/program.rs
+++ b/winit/src/program.rs
@@ -401,22 +401,22 @@ where
);
}
- fn received_url(
- &mut self,
- event_loop: &winit::event_loop::ActiveEventLoop,
- url: String,
- ) {
- self.process_event(
- event_loop,
- Event::EventLoopAwakened(
- winit::event::Event::PlatformSpecific(
- winit::event::PlatformSpecific::MacOS(
- winit::event::MacOS::ReceivedUrl(url),
- ),
- ),
- ),
- );
- }
fn about_to_wait(
&mut self,
@@ -762,19 +762,19 @@ async fn run_instance<P, C>(
}
}
}
- event::Event::PlatformSpecific(
- event::PlatformSpecific::MacOS(
- event::MacOS::ReceivedUrl(url),
- ),
- ) => {
- runtime.broadcast(
- subscription::Event::PlatformSpecific(
- subscription::PlatformSpecific::MacOS(
- subscription::MacOS::ReceivedUrl(url),
- ),
- ),
- );
- }
event::Event::UserEvent(action) => {
run_action(
action, |
I have created a PR to update our winit fork to v0.30.8 for fixing this issue at iced-rs/winit: iced-rs/winit#15 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Is your issue REALLY a bug?
Is there an existing issue for this?
Is this issue related to iced?
What happened?
I have created a minimal reproduction:
This example should create a transparent window, but it was actually opaque:
What is the expected behavior?
With iced v0.13.1, it works fine:
Here is the code (slightly modified due to API changes since 0.13):
Version
master
Operating System
macOS
Do you have any log output?
No response
The text was updated successfully, but these errors were encountered: