-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #279 and #100 plotting updates #282
Draft
bnubald
wants to merge
63
commits into
icenet-ai:v0.2.9_dev
Choose a base branch
from
bnubald:279_plotting_updates
base: v0.2.9_dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
And PlateCaree global map forecast output
Now, can specify lat/lon for lambert azimuthal equal area plotting too, and general option support
Incomplete wwith TODOs
…x overlap w/ northfacing
This was
linked to
issues
Jul 9, 2024
…trics Also started work towards enabling lat/lon bounds for metrics
…... region input Also, redefine lat/lon projection as geographic projection throughout
…ividual numpy files
…pyproj for reproject
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #279 and #100
There is still work to be done on using the lat/lon which will likely need some refactoring of the
Masks
class. Whenprocess_regions
is called andMasks
is provided to it here:icenet/icenet/plotting/forecast.py
Lines 1486 to 1488 in f128536
It defines a pixel based slice which is set by
getitem
in the Masks class. (This is the case for all timesprocess_regions
is called inforecast.py
above)icenet/icenet/data/sic/mask.py
Lines 305 to 315 in f128536
But, the Masks class needs to account for when the bounds are defined by lat/lon. This is needed when the Mask is used to weight the metric, for example:
icenet/icenet/plotting/forecast.py
Lines 88 to 100 in f128536