Update client IceProtocolConnection to schedule first heartbeat only … #4115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…once connected
This is a small fix to the "send heartbeat" logic in IceProtocolConnection.
Prior to this PR, an Ice client connection could send heartbeats before receiving the initial ValidateConnection frame from the server. That's a minor violation of the
iceprotocol that neither Ice nor IceRPC would detect. It's also very unlikely. Nevertheless, a small bug.I also added a test to verify that an
iceclient connection that doesn't write anything is not aborted by the server connection idle monitor.