Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Homepage Feedback 2 #60

Open
bhavikbhagat93 opened this issue Aug 4, 2023 · 6 comments
Open

🐛 Homepage Feedback 2 #60

bhavikbhagat93 opened this issue Aug 4, 2023 · 6 comments
Assignees
Labels
0.6.0 bug Something isn't working

Comments

@bhavikbhagat93
Copy link

bhavikbhagat93 commented Aug 4, 2023

Describe the bug

Documenting some findings from the RDPC homepage in comparison with the figma mockups.
image

  1. Padding issue for logo and login button on header
  2. Login button text is incorrect
  3. Link to "Back to ICGO argo" looks bolded
  4. RDPC Clinical heading is bolded
  5. Text padding issue with "Login" button
  6. Spacing between Overture banner and footer
  7. Change Hero banner background image for better readability. New Image link : https://files.slack.com/files-pri/T029E087Q-F05LAJYHQ20/planet_background.png

Link to figma: https://www.figma.com/file/O9jdbXSZMQf5F34OJAhyRT/ARGO-RPDC%3A-Exploration?type=design&node-id=96-66763&mode=design&t=tOmjne8SZadFJf5B-0

@bhavikbhagat93 bhavikbhagat93 added the bug Something isn't working label Aug 4, 2023
@ciaranschutte
Copy link
Contributor

Link to "Back to ICGC Argo" weight is 600 , matches figma, do we want to to make it lighter? @bhavikbhagat93 @patrickdsantos

@ciaranschutte
Copy link
Contributor

6 - Spacing between Overture banner and footer
cannot replicate - please comment with specific browser / any other important details - weird resize dimension etc

@bhavikbhagat93
Copy link
Author

6 - Spacing between Overture banner and footer cannot replicate - please comment with specific browser / any other important details - weird resize dimension etc

It was on chrome browser and we were view on external monitor. Let me try and reproduce this on my end.

@patrickdsantos
Copy link

patrickdsantos commented Aug 14, 2023

Hello Team! My feedback is below:

  1. You are correct the weight is the same as the mocks. Could've been the monitor we were originally QA-ing on. However could we replace the "<" with the right chevron symbol in .svg from the mock? (Attached below)

chevronRight
chevronRight

  1. Could not replicate on my end either. Fine to leave it as is.

Thank you team!

@bhavikbhagat93
Copy link
Author

@ciaranschutte I was able to see this on chrome browser. Link : https://ui.rdpc-dev.cancercollaboratory.org/
Also, my mac resolution is set to "More Space", could that be the reason?

image

Screenshot 2023-08-15 at 1 52 33 PM

@ciaranschutte
Copy link
Contributor

@bhavikbhagat93 that's it ! - "more space" - I can reproduce now - will take a look

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0.6.0 bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants