Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warning: componentWillMount has been renamed — SideEffect(DocumentTitle) #54

Open
tossy310 opened this issue Jul 7, 2024 · 1 comment

Comments

@tossy310
Copy link
Member

tossy310 commented Jul 7, 2024

react-dom.development.js:67 Warning: componentWillMount has been renamed, and is not recommended for use. See https://reactjs.org/link/unsafe-component-lifecycles for details.

* Move code with side effects to componentDidMount, and set initial state in the constructor.
* Rename componentWillMount to UNSAFE_componentWillMount to suppress this warning in non-strict mode. In React 18.x, only the UNSAFE_ name will work. To rename all deprecated lifecycles to their new names, you can run `npx react-codemod rename-unsafe-lifecycles` in your project source folder.

Please update the following components: SideEffect(DocumentTitle)

We use https://github.com/gaearon/react-document-title from DocumentTitleUpdater, and react-document-title depends on https://github.com/gaearon/react-side-effect, which uses componentWillMount.

We may need to find alternative way to update the document title.

@tossy310
Copy link
Member Author

tossy310 commented Jul 7, 2024

And this is a blocker to update react to 18.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant