Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor context menu to make no assumptions about resource location #3329

Open
tom-englert opened this issue Nov 16, 2024 · 0 comments
Open
Labels
Enhancement Areas for improvement

Comments

@tom-englert
Copy link
Contributor

Header and Category in the IContextMenuEntryMetadata are resource keys, that are evaluated at runtime, where the resource location is assumed to be in the main assembly. This makes it impossible for a plugin to provide a localized header or category.

Header and category should be removed from the IContextMenuEntryMetadata and its corresponding ExportAttribute implementations, and moved to the IContextMenuEntry.
Implementations of IContextMenuEntry with the ExportContextMenuEntryAttribute should implement the Header and Category properties by return the string from the ResourceMangager of the ILSpy assembly with the same key that was provided in the corresponding ExportContextMenuEntryAttribute before.

@tom-englert tom-englert added the Enhancement Areas for improvement label Nov 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement Areas for improvement
Projects
None yet
Development

No branches or pull requests

1 participant