Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFC: Filter out classes already taken #1028

Open
1 of 5 tasks
MinhxNguyen7 opened this issue Nov 9, 2024 · 4 comments
Open
1 of 5 tasks

RFC: Filter out classes already taken #1028

MinhxNguyen7 opened this issue Nov 9, 2024 · 4 comments
Assignees
Labels
enhancement Improvements to the user experience RFC Request for comment

Comments

@MinhxNguyen7
Copy link
Member

MinhxNguyen7 commented Nov 9, 2024

Description

  • Using data from PeterPortal, filter out classes that came before the current quarter quarter in the four-year plan.
  • This would probably involve an actual PeterPortal API (as opposed to AAPI).
  • My current imagination is that AA backend would authenticate the user with Google, request PPAPI server-side with a shared secret for the four-year plan, then request the AAPI to filter out those classes.

Tasks

  • Specify the user interactions for the feature (Minh).
    • For UI, I'd imagine it's just a toggle in the search pane that's only visible if you're authenticated.
    • However, we have to think about how to communicate the idea that the data is pulled from PeterPortal.
  • Work out communications between PP and AA.
    • What if someone has multiple 4-year plans in PeterPortal?
  • Decide on a timeline.
  • Implement the logic to filter out classes depending on the user on the backend (with authentication).
    • Complete by Wednesday 2/12
  • Implement the feature on the frontend.

Related Issues

  • Requires #1027
@MinhxNguyen7 MinhxNguyen7 added enhancement Improvements to the user experience RFC Request for comment labels Nov 9, 2024
@github-project-automation github-project-automation bot moved this to Backlog 🥱 in AntAlmanac Nov 9, 2024
@MinhxNguyen7
Copy link
Member Author

@js0mmer could you comment on this?

@js0mmer
Copy link
Member

js0mmer commented Nov 21, 2024

Sounds reasonable. I'll create an issue for it. To clarify:

  • We'll set up a REST endpoint in our API for querying previously taken courses that takes a google account id and the current quarter as params
  • We'll verify a secret key that is passed in the Authorization header so only AA can use this endpoint
  • We'll return a string[] of course ids for all courses that come before the specified quarter in the user's planner(s)

@MinhxNguyen7
Copy link
Member Author

MinhxNguyen7 commented Nov 22, 2024

Yes. What is the course ID though? It has to be the course title right? I.e., "ICS 33"

@js0mmer
Copy link
Member

js0mmer commented Nov 22, 2024

Yes, I mean the ID as AnteaterAPI has it defined for each course. So "I&CSCI33"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improvements to the user experience RFC Request for comment
Projects
Status: Selected for Development
Development

No branches or pull requests

3 participants