Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace public mapbox token #718

Closed
EricPedley opened this issue Oct 2, 2023 · 2 comments · Fixed by #730
Closed

Replace public mapbox token #718

EricPedley opened this issue Oct 2, 2023 · 2 comments · Fixed by #730
Assignees
Labels
high High priority issue

Comments

@EricPedley
Copy link
Member

Instead of having a public token, have a server that can proxy requests or something. We have about 20 days to do this 😳
image

@EricPedley EricPedley added the high High priority issue label Oct 2, 2023
@EricPedley EricPedley moved this to Backlog 🥱 in AntAlmanac Oct 5, 2023
@EricPedley EricPedley moved this from Backlog 🥱 to In Progress 🤠 in AntAlmanac Oct 5, 2023
@EricPedley
Copy link
Member Author

Turns out we exceeded the free tier because usage of the map spiked around the first day of classes.
image

@ap0nia
Copy link
Collaborator

ap0nia commented Oct 11, 2023

A (possibly) difficult issue to tackle is how we could minimize the number of map requests made for the routing (if at all possible). You can view the many, many requests made for routing if you open the network tab and repeatedly switch between the selected day.

image

I'm not looking too closely at the map right now, but a big reason for why this occurs should be a result of how the data fetching of each route is tied to its rendering, i.e. the component fetches route data when its corresponding day is selected and rendered. It's possible that this isn't the root cause of the issue, but it could be something to consider in a followup.

@ap0nia ap0nia linked a pull request Oct 12, 2023 that will close this issue
@github-project-automation github-project-automation bot moved this from In Progress 🤠 to Done 🤩 in AntAlmanac Oct 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
high High priority issue
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants