Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicate code in helpers.ts and course-helpers.ts #760

Closed
MinhxNguyen7 opened this issue Oct 26, 2023 · 0 comments · Fixed by #764
Closed

Duplicate code in helpers.ts and course-helpers.ts #760

MinhxNguyen7 opened this issue Oct 26, 2023 · 0 comments · Fixed by #764
Assignees
Labels
codefix Refactoring or improving the codebase medium Medium priority issue

Comments

@MinhxNguyen7
Copy link
Member

In #750, we found that there are two WebSOC caches. It turns out that a large part of course-helpers.ts is duplicated in helpers.ts. I vaguely remember extracting part of helpers into course-helpers, but I probably forgot to delete the old stuff.

As an aside, IMO, helpers.ts should be split up into multiple namespaces, whether that be different files, classes, or both.

@MinhxNguyen7 MinhxNguyen7 added codefix Refactoring or improving the codebase medium Medium priority issue labels Oct 26, 2023
@MinhxNguyen7 MinhxNguyen7 self-assigned this Oct 26, 2023
@MinhxNguyen7 MinhxNguyen7 moved this to In Progress 🤠 in AntAlmanac Oct 26, 2023
@MinhxNguyen7 MinhxNguyen7 moved this from In Progress 🤠 to Review 🧐 in AntAlmanac Oct 27, 2023
@github-project-automation github-project-automation bot moved this from Review 🧐 to Done 🤩 in AntAlmanac Oct 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
codefix Refactoring or improving the codebase medium Medium priority issue
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant