Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: themeStore #854

Closed
KevinWu098 opened this issue Jan 16, 2024 · 0 comments · Fixed by #847
Closed

refactor: themeStore #854

KevinWu098 opened this issue Jan 16, 2024 · 0 comments · Fixed by #847
Labels
codefix Refactoring or improving the codebase

Comments

@KevinWu098
Copy link
Member

Because I'm a pedant, I'll say that the the better implementation of appTheme == "dark" would be appTheme.isDark() so that "dark" and "light" aren't magic values. Intellisense tells you, but you ideally shouldn't need Intellisence. I say it for the sake of future code.

Originally posted by @MinhxNguyen7 in #847 (review)
@github-project-automation github-project-automation bot moved this to Backlog 🥱 in AntAlmanac Jan 16, 2024
@KevinWu098 KevinWu098 added the codefix Refactoring or improving the codebase label Jan 16, 2024
@KevinWu098 KevinWu098 mentioned this issue Jan 24, 2024
Merged
@KevinWu098 KevinWu098 linked a pull request Jan 24, 2024 that will close this issue
Deprecate isDarkMode in favor of useThemeStore #847
Merged
@EricPedley EricPedley moved this from Backlog 🥱 to Review 🧐 in AntAlmanac Jan 31, 2024
@github-project-automation github-project-automation bot moved this from Review 🧐 to Done 🤩 in AntAlmanac Feb 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
codefix Refactoring or improving the codebase
Projects
AntAlmanac
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Deprecate isDarkMode in favor of useThemeStore icssc/AntAlmanac
1 participant
@KevinWu098