Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: read meeting data from db #105

Merged
merged 5 commits into from
May 21, 2024
Merged

feat: read meeting data from db #105

merged 5 commits into from
May 21, 2024

Conversation

KevinWu098
Copy link
Member

@KevinWu098 KevinWu098 commented May 20, 2024 •
edited
Loading

Summary

  1. Read start and end times from DB instead of hardcoding
  2. Fix PageData type import

chrome-capture-2024-4-20

Closes #103

@KevinWu098 KevinWu098 temporarily deployed to staging-105 May 20, 2024 22:52 — with GitHub Actions Inactive
@KevinWu098 KevinWu098 temporarily deployed to staging-105 May 20, 2024 22:58 — with GitHub Actions Inactive
@seancfong seancfong linked an issue May 20, 2024 that may be closed by this pull request
Retrieve availability range from DB instead of hard-coding #103
Closed
@KevinWu098 KevinWu098 temporarily deployed to staging-105 May 20, 2024 23:18 — with GitHub Actions Inactive
@KevinWu098 KevinWu098 temporarily deployed to staging-105 May 21, 2024 00:07 — with GitHub Actions Inactive
@KevinWu098 KevinWu098 changed the title feat: read meeting time range from db feat: read meeting data from db May 21, 2024
MinhxNguyen7
MinhxNguyen7 approved these changes May 21, 2024
View reviewed changes
Copy link
Member

@MinhxNguyen7 MinhxNguyen7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@MinhxNguyen7 MinhxNguyen7 merged commit d7919d5 into main May 21, 2024
1 check passed
@KevinWu098 KevinWu098 deleted the kw/retrieve-availability-range-db branch October 17, 2024 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MinhxNguyen7 MinhxNguyen7 MinhxNguyen7 approved these changes

@seancfong seancfong Awaiting requested review from seancfong

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Retrieve availability range from DB instead of hard-coding
2 participants
@KevinWu098 @MinhxNguyen7