-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
135 selecting some calendar dates in dec 2024 jan 2025 unintentionally selects others #142
base: main
Are you sure you want to change the base?
Conversation
* feat: add commitlint for commit messages * feat: ✨ add devmoji for emoji commits
* Changed page title * Dynamically pulled meeting name and added it to page title and description * Added comments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just one minor fix before we can merge
…unintentionally-selects-others' of https://github.com/icssc/ZotMeet into 135-selecting-some-calendar-dates-in-dec-2024-jan-2025-unintentionally-selects-others
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
mm.. the diff looks weird... can we merge main into this branch?
How's the progress on this PR? You might have to checkout a new branch and push your changes onto there if this branch is too dirty. |
We changed the valueOf() function in the zotdate file to use built-in function getTime() instead of having values hardcoded in for comparison.
Main (line 59):
/**
* Used for comparing dates with < and >
* @return a number proportional to the amount of days elapsed since 0 AD, although not exact due to leap years
/
valueOf(): number {
return (
this.day.getDate() +
this.day.getMonth() * 31 +
this.day.getFullYear() * 366
);
}
Branch:
/*
* Used for comparing dates with < and >
* @returns an exact number that refers to the number of milliseconds that have passed since Jan 1, 1970. Can use
* valueOf() to check if the value of two Dates is the same.
*/
valueOf(): number {
const res = this.day.getTime();
return res;
}