Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: create save, login flow #62

Merged
merged 33 commits into from
Mar 26, 2024
Merged

feat: create save, login flow #62

merged 33 commits into from
Mar 26, 2024

Conversation

KevinWu098
Copy link
Member

@KevinWu098 KevinWu098 commented Mar 1, 2024

Summary

  1. Create an auth flow when editing / saving your availability
  2. Editing is always allowed and saving triggers the auth flow
  3. The auth flow pops up a login modal. On successful login, the modal closes

This PR is entirely frontend sided as the backend endpoints / db connections haven't been setup yet.

Progress

  • Set up basic ui
  • Link together auth flow (only login)
  • Style cleanup
  • Modal on mobile

Screenshots

Screenshot 2024-02-29 at 7 48 57 PM

Future Followup

  1. Connect it up with the backend
  2. Have options for creating an account
  3. Styling

Note

Currently, this PR is using the old auth for easier development. Those changes should be reverted before merge.

Future Followup

  1. Update the UI to allow for account creation (tabs between Login, Register)

Closes #59

@KevinWu098 KevinWu098 requested a review from seancfong March 1, 2024 03:49
@KevinWu098 KevinWu098 marked this pull request as ready for review March 6, 2024 08:37
@KevinWu098 KevinWu098 temporarily deployed to staging-62 March 6, 2024 08:38 — with GitHub Actions Inactive
@MinhxNguyen7 MinhxNguyen7 marked this pull request as draft March 7, 2024 07:26
@MinhxNguyen7
Copy link
Member

Marked this as draft because it's non-functional on mobile. If it were ugly, I would've let it slide.

@KevinWu098 KevinWu098 temporarily deployed to staging-62 March 7, 2024 23:11 — with GitHub Actions Inactive
@KevinWu098 KevinWu098 marked this pull request as ready for review March 7, 2024 23:25
@MinhxNguyen7 MinhxNguyen7 requested review from MinhxNguyen7 and removed request for seancfong March 7, 2024 23:30
@KevinWu098 KevinWu098 temporarily deployed to staging-62 March 7, 2024 23:42 — with GitHub Actions Inactive
@KevinWu098 KevinWu098 temporarily deployed to staging-62 March 7, 2024 23:56 — with GitHub Actions Inactive
@MinhxNguyen7 MinhxNguyen7 requested review from seancfong and removed request for MinhxNguyen7 March 8, 2024 00:21
prisma/dev.db Outdated Show resolved Hide resolved
@KevinWu098 KevinWu098 temporarily deployed to staging-62 March 13, 2024 06:35 — with GitHub Actions Inactive
@KevinWu098 KevinWu098 temporarily deployed to staging-62 March 13, 2024 06:49 — with GitHub Actions Inactive
@KevinWu098 KevinWu098 requested a review from seancfong March 13, 2024 06:49
Copy link
Member

@seancfong seancfong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@KevinWu098 The modal front-end looks good to me. Not sure if you want this merged into main and merge main into your other branch or directly merge this branch into your lucia/drizzle one.

@MinhxNguyen7 MinhxNguyen7 merged commit 3781e47 into main Mar 26, 2024
2 checks passed
KevinWu098 added a commit that referenced this pull request Mar 27, 2024
MinhxNguyen7 pushed a commit that referenced this pull request Mar 31, 2024
* feat: ✨ initial tabs setup

* style: 🎨 adjust tabs

* style: 🎨 adjust bg and block colors

* style: 🎨 borders

* style: 🎨 set days to 5, simplify styles

* style: 🎨 responsiveness

* feat: ✨ add columns prop, based on viewport width

* style: 🎨 use sean's tabs

* chore: 🔧 remove old availability pages

* chore: 🔧 rename v2 to default

* fix: 🐛 change sample availability date constructor

* feat: ✨ setup stores, buttons for saving

* fix: 🐛 revert auth changes for easier development

* feat: basic modal component

* feat: ✨ various modal improvements (esc, backdrop, close icon), styling

* feat: get login result

* chore: remove unused code

* fix: set unsaved state to false only on success

* fix: add support for two forms (login, guest)

* style: prevent ui shift at smaller screens

* chore: create placeholder guest schema

* fix: handle mobile/desktop with window width

* style: mobile styling of modal

* style: decrease button padding on mobile

* rename LoginFlow to LoginModal

* chore: remove testing code, unused imports

* fix: correct guest input binding

* feat: ✨ correct login, register to match prisma schema

* style: 🎨 make elements more visible w/ bg color

* feat: ✨ correct schema and ui to just have username, email, pw

* feat: ✨ rename username to displayName

* feat: ✨ setup database

* chore: 🔧 add dev db to gitignore

* refactor: rename boolean stores

* refactor: rename to auth-modal

* refactor: ♻️ add interface, rename for login data

* fix: 🐛 update username to displayName in drizzle schema

* chore: 🔧 install dependencies, setup drizzle studio

* feat: ✨ update schema

* chore: 🔧 uninstall unused lucia dep

* feat: ✨ update lucia to v3

* feat: ✨ migrate login/registration

* fix: 🐛 update load function for load

* fix: 🐛 clear superform warning

* fix: 🐛 disable google auth config

* feat: ✨ update logout

* fix: 🐛 call dotenv config

* chore: 🔧 remove testing code

* fix: 🐛 adjust lucia config

* fix: 🐛 correct postgres client

* fix: 🐛 correct schema to use text, not uuid type

* chore: 🔧 remove console logs

* chore: 🔧 remove log files, update config

* feat: ✨ migrate google oauth

* chore: 🔧 remove console log

* chore: 🔧 update deps

* chore: 🔧 update deps pt2

* feat: ✨ disable google auth, correct schema

* fix: 🐛 disable google in lucia config

* fix: 🐛 correct bugs and errors from #62

* chore: 🔧 extract existingUser function

* chore: 🔧 remove console log

* fix: 🐛 use scrypt over oslo

* chore: 🔧 remove prisma

* feat: ✨ update ProfileCard w/ auth buttons and info

* feat: ✨ update login ui

* fix: 🐛 cleanup login

* feat: ✨ update register ui

* chore: 🔧 add error into form error message

---------

Co-authored-by: Sean Fong <[email protected]>
@KevinWu098 KevinWu098 deleted the kw/59-create-save-flow branch October 17, 2024 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create Login Flow
3 participants