Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-style meeting setup page #83

Merged
merged 7 commits into from
Apr 3, 2024
Merged

Re-style meeting setup page #83

merged 7 commits into from
Apr 3, 2024

Conversation

seancfong
Copy link
Member

@seancfong seancfong commented Apr 3, 2024 •
edited
Loading

Summary

  • Updated logo on top left corner and tweaked logo positioning on desktop
  • Name input field will autofocus on component mount
    • (Note that on mobile, the user's keyboard won't pop up until they tap on the input field. However, it will still have the blue border)
  • Some style and typography tweaks to the summary page

Preview

image
image

(on safari, where the vertical screen real-estate is pretty limited)
IMG_A1EA6999ADEF-1

@seancfong seancfong linked an issue Apr 3, 2024 that may be closed by this pull request
Re-style meeting setup page #79
Closed
@seancfong seancfong temporarily deployed to staging-83 April 3, 2024 06:31 — with GitHub Actions Inactive
@seancfong seancfong temporarily deployed to staging-83 April 3, 2024 06:41 — with GitHub Actions Inactive
@seancfong seancfong temporarily deployed to staging-83 April 3, 2024 06:51 — with GitHub Actions Inactive
@seancfong seancfong temporarily deployed to staging-83 April 3, 2024 06:54 — with GitHub Actions Inactive
@seancfong seancfong temporarily deployed to staging-83 April 3, 2024 06:56 — with GitHub Actions Inactive
@seancfong seancfong requested a review from MinhxNguyen7 April 3, 2024 07:01
@seancfong
Copy link
Member Author

@MinhxNguyen7 Ready for review

@MinhxNguyen7 MinhxNguyen7 marked this pull request as ready for review April 3, 2024 21:23
MinhxNguyen7
MinhxNguyen7 approved these changes Apr 3, 2024
View reviewed changes
Copy link
Member

@MinhxNguyen7 MinhxNguyen7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

I'm not necessarily sold on the time picker being up there, but I don't have a better idea yet, and let's just get this in

@MinhxNguyen7 MinhxNguyen7 merged commit d663e8d into main Apr 3, 2024
2 checks passed
@KevinWu098 KevinWu098 deleted the 79-re-style-meeting-setup-page branch October 17, 2024 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MinhxNguyen7 MinhxNguyen7 MinhxNguyen7 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Re-style meeting setup page
2 participants
@seancfong @MinhxNguyen7