Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: ✨ set up ACLs and migration user #92

Merged
merged 2 commits into from
Apr 27, 2024
Merged

feat: ✨ set up ACLs and migration user #92

merged 2 commits into from
Apr 27, 2024

Conversation

ecxyzzy
Copy link
Member

@ecxyzzy ecxyzzy commented Apr 23, 2024

Closes #87.

Copy link
Member

@MinhxNguyen7 MinhxNguyen7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks fine, but we're still getting permission denied when trying to access/write to the DB.

You can reproduce this by clicking Login, then Sign Up, then signing up with some random credentials. If the error changes to something other than a permission error, it's probably working.

Thanks for the help.

@ecxyzzy ecxyzzy requested a review from MinhxNguyen7 April 24, 2024 17:45
@ecxyzzy
Copy link
Member Author

ecxyzzy commented Apr 24, 2024

Yeah sorry I think I messed up the sequencing when applying the ACLs so I had to explicitly grant all permissions through psql. To make sure I dropped the existing dev schema and reran migrate, and the permissions are correct now (as verified through the CLI and by testing on the staging build).

Copy link
Member

@MinhxNguyen7 MinhxNguyen7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine. Seems to work.

For the sake of moving faster, this should be merged, but, at some point, can you write in the file or readme what to do/what you did with the SQL file with all the grants?

@MinhxNguyen7 MinhxNguyen7 merged commit e84ce67 into main Apr 27, 2024
1 check passed
@KevinWu098 KevinWu098 deleted the db-acls branch October 17, 2024 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Document DB Deployment/Migrations Troubleshooting
2 participants