Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added delete confirmation feature #78

Merged
merged 5 commits into from
Feb 9, 2025
Merged

added delete confirmation feature #78

merged 5 commits into from
Feb 9, 2025

Conversation

tentsundue
Copy link
Contributor

@tentsundue tentsundue commented Jan 25, 2025 •
edited
Loading

  • Imported chakra popover components
  • replaced delete button with a popover
  • popover contains "are you sure" message, cancel button that closes the modal, and confirm button that deletes the item

@tentsundue tentsundue linked an issue Jan 25, 2025 that may be closed by this pull request
feat: Add additional confirmation step before deleting item #66
Closed
brelieu05
brelieu05 reviewed Feb 4, 2025
View reviewed changes
Copy link
Contributor

@brelieu05 brelieu05 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

I see it on my side too
image

NwinNwin
NwinNwin approved these changes Feb 9, 2025
View reviewed changes
Copy link
Member

@NwinNwin NwinNwin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I moved delete button to its won component. but otherwise, LGTM!

@NwinNwin NwinNwin merged commit c229baa into main Feb 9, 2025
1 check passed
@NwinNwin NwinNwin deleted the delete-confirmation-popover branch February 10, 2025 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brelieu05 brelieu05 brelieu05 left review comments

@NwinNwin NwinNwin NwinNwin approved these changes

@ElianMalessy ElianMalessy Awaiting requested review from ElianMalessy

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat: Add additional confirmation step before deleting item
3 participants
@tentsundue @brelieu05 @NwinNwin